task_local context over context objects

- interner impls logically separate from API in orchid-base (default host interner still in base for testing)
- error reporting, logging, and a variety of other features passed down via context in extension, not yet in host to maintain library-ish profile, should consider options
- no global spawn mechanic, the host has a spawn function but extensions only get a stash for enqueuing async work in sync callbacks which is then explicitly, manually, and with strict order popped and awaited
- still deadlocks nondeterministically for some ungodly reason

orchid-host/src/ctx.rs

@@ -3,19 +3,28 @@ use std::num::{NonZero, NonZeroU16};
 use std::rc::{Rc, Weak};
 use std::{fmt, ops};
 
+use futures::future::LocalBoxFuture;
 use futures_locks::RwLock;
 use hashbrown::HashMap;
-use orchid_base::builtin::Spawner;
-use orchid_base::interner::Interner;
+use orchid_base::logging::Logger;
 
 use crate::api;
 use crate::expr_store::ExprStore;
 use crate::system::{System, WeakSystem};
 use crate::tree::WeakRoot;
 
+pub trait JoinHandle {
+	fn abort(&self);
+	fn join(self: Box<Self>) -> LocalBoxFuture<'static, ()>;
+}
+
+pub trait Spawner {
+	fn spawn_obj(&self, fut: LocalBoxFuture<'static, ()>) -> Box<dyn JoinHandle>;
+}
+
 pub struct CtxData {
-	pub i: Interner,
-	pub spawn: Spawner,
+	spawner: Rc<dyn Spawner>,
+	pub msg_logs: Logger,
 	pub systems: RwLock<HashMap<api::SysId, WeakSystem>>,
 	pub system_id: RefCell<NonZeroU16>,
 	pub exprs: ExprStore,
@@ -37,16 +46,25 @@ impl WeakCtx {
 }
 impl Ctx {
 	#[must_use]
-	pub fn new(spawn: Spawner) -> Self {
+	pub fn new(msg_logs: Logger, spawner: impl Spawner + 'static) -> Self {
 		Self(Rc::new(CtxData {
-			spawn,
-			i: Interner::default(),
+			msg_logs,
+			spawner: Rc::new(spawner),
 			systems: RwLock::default(),
 			system_id: RefCell::new(NonZero::new(1).unwrap()),
 			exprs: ExprStore::default(),
 			root: RwLock::default(),
 		}))
 	}
+	/// Spawn a parallel future that you can join at any later time.
+	///
+	/// Don't use this for async Drop, use [orchid_base::stash::stash] instead.
+	/// If you use this for an actor object, make sure to actually join the
+	/// handle.
+	#[must_use]
+	pub fn spawn(&self, fut: impl Future<Output = ()> + 'static) -> Box<dyn JoinHandle> {
+		self.spawner.spawn_obj(Box::pin(fut))
+	}
 	#[must_use]
 	pub(crate) async fn system_inst(&self, id: api::SysId) -> Option<System> {
 		self.systems.read().await.get(&id).and_then(WeakSystem::upgrade)
@@ -62,9 +80,6 @@ impl Ctx {
 }
 impl fmt::Debug for Ctx {
 	fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-		f.debug_struct("Ctx")
-			.field("i", &self.i)
-			.field("system_id", &self.system_id)
-			.finish_non_exhaustive()
+		f.debug_struct("Ctx").field("system_id", &self.system_id).finish_non_exhaustive()
 	}
 }