Traditional route appears to work

Beginnings of dylib extensions, entirely untestted

orchid-host/src/subprocess.rs

@@ -1,32 +1,34 @@
-use std::io;
+use std::{io, process};
 
-use async_process;
 use futures::io::BufReader;
-use futures::{self, AsyncBufReadExt};
-use orchid_base::logging::logger;
+use futures::{self, AsyncBufReadExt, StreamExt};
+use orchid_base::logging::log;
+#[cfg(feature = "tokio")]
+use tokio_util::compat::{TokioAsyncReadCompatExt, TokioAsyncWriteCompatExt};
 
 use crate::ctx::Ctx;
 use crate::extension::ExtPort;
 
+#[cfg(feature = "tokio")]
 pub async fn ext_command(cmd: std::process::Command, ctx: Ctx) -> io::Result<ExtPort> {
-	let mut child = async_process::Command::from(cmd)
-		.stdin(async_process::Stdio::piped())
-		.stdout(async_process::Stdio::piped())
-		.stderr(async_process::Stdio::piped())
+	let name = cmd.get_program().to_string_lossy().to_string();
+	let mut child = tokio::process::Command::from(cmd)
+		.stdin(process::Stdio::piped())
+		.stdout(process::Stdio::piped())
+		.stderr(process::Stdio::piped())
 		.spawn()?;
+	std::thread::spawn(|| {});
 	let stdin = child.stdin.take().unwrap();
 	let stdout = child.stdout.take().unwrap();
-	let mut child_stderr = child.stderr.take().unwrap();
+	let child_stderr = child.stderr.take().unwrap();
 	let _ = ctx.spawn(Box::pin(async move {
 		let _ = child;
-		let mut reader = BufReader::new(&mut child_stderr);
-		loop {
-			let mut buf = String::new();
-			if 0 == reader.read_line(&mut buf).await.unwrap() {
-				break;
-			}
-			logger().log(buf.strip_suffix('\n').expect("Readline implies this"));
+		let mut lines = BufReader::new(child_stderr.compat()).lines();
+		while let Some(line) = lines.next().await {
+			// route stderr with an empty category string. This is not the intended logging
+			// method
+			writeln!(log("stderr"), "{} err> {}", name, line.expect("Readline implies this")).await;
 		}
 	}));
-	Ok(ExtPort { input: Box::pin(stdin), output: Box::pin(stdout) })
+	Ok(ExtPort { input: Box::pin(stdin.compat_write()), output: Box::pin(stdout.compat()) })
 }